[
https://issues.apache.org/jira/browse/LUCENE-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hoss Man updated LUCENE-5961:
-----------------------------
Attachment: LUCENE-5961.patch
A whole lot of new tests, and fixed behavior for several ValueSources.
I added a few TODOs in the test related to a couple of ValueSource classes
where i wasn't sure what the "correct" behavior should even be - but i'm not
planning on trying to tackle those here. i just wanted to note in the test
that the expected behavior is unclear & untested.
> FunctionValues.exist(int) isn't returning false in cases where it should for
> many "math" based value sources
> ------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-5961
> URL: https://issues.apache.org/jira/browse/LUCENE-5961
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Hoss Man
> Attachments: LUCENE-5961.patch, LUCENE-5961.patch
>
>
> The FunctionValues class contains an exist(int doc) method with a default
> implementation that returns true - field based DocValues override this method
> as appropriate, but most of the "function" based subclasses in the code
> (typically anonymous subclasses of "FloatDocValues") don't override this
> method when wrapping other ValueSources.
> So for example: the FunctionValues returned by
> ProductFloatFunction.getValues() will say that a value exists for any doc,
> even if that ProductFloatFunction wraps two FloatFieldSources that don't
> exist for any docs
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
