[
https://issues.apache.org/jira/browse/LUCENE-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14176811#comment-14176811
]
Robert Muir commented on LUCENE-6013:
-------------------------------------
Patch looks good.
I'm afraid about FieldInfosReader/Writer, can you please look this over one
more time just to ensure its ok?
Since it was writing a bit for this before, this is absolutely the most likely
place for bugs in the patch... and the worse place for my brain to hit
TooManyUnrelatedStyleChangesException when reviewing it :(
> Remove IndexableFieldType.indexed()
> -----------------------------------
>
> Key: LUCENE-6013
> URL: https://issues.apache.org/jira/browse/LUCENE-6013
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 5.0, Trunk
>
> Attachments: LUCENE-6013.patch
>
>
> Like LUCENE-6006, here's another pre-cursor for LUCENE-6005
> ... because I think it's important to nail down Lucene's low-schema
> (FieldType/FieldInfos) semantics before adding a high-schema.
> IndexableFieldType.indexed() is redundant with
> IndexableFieldType.indexOptions() != null, so we should remove it,
> codecs shouldn't have to write/read it, high-schema should not configure it,
> etc.
> Similarly, the FieldInfo.indexed bit is redundant, so I removed it, but I
> left the sugar API (FieldInfo.isIndexed) and implement it as just
> checking IndexOptions != null.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
