Robert Muir created LUCENE-6014:
-----------------------------------

             Summary: Lucene41PostingsWriter.advance() doc scanning is buggy
                 Key: LUCENE-6014
                 URL: https://issues.apache.org/jira/browse/LUCENE-6014
             Project: Lucene - Core
          Issue Type: Bug
            Reporter: Robert Muir


The "code duplication" here to optimize scanning to target after "possible 
skipping" looks really buggy.

For example, it never checks to refill buffer in the loop if it gets exhausted. 
But the code gives no indication about why its safe for it to make this 
assumption.

If nobody understands why this optimization is allowed to make such a shortcut, 
then please add a comment indicating why, with asserts tied to exact specific 
constants in skipwriter (if applicable), otherwise i will remove the 
optimization completely in 72 hours.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to