[
https://issues.apache.org/jira/browse/LUCENE-6018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14179950#comment-14179950
]
Robert Muir commented on LUCENE-6018:
-------------------------------------
{quote}
I think its enough if "ant jenkins-hourly" indirectly or directly depends on
that.
{quote}
But i think committers should still have a simple target (even if its called
via smoketester, thats fine) to do this? I know i rarely change dependencies,
but when I do, i am fine with it taking extra time to be correct before
committing.
> move libversions check out of precommit to another target?
> ----------------------------------------------------------
>
> Key: LUCENE-6018
> URL: https://issues.apache.org/jira/browse/LUCENE-6018
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
>
> The libversions check can be especially heavy (taking minutes and downloading
> a lot?). Lately, i cannot get it to finish. To run precommit checks i have to
> hack build.xml and then revert it.
> Can we move this from precommit to another target? A few things:
> 1. i dont think most commits contain changes to third party dependencies, so
> it discourages precommit, which is already hard to get people to run.
> 2. most commits that DO contain changes to third party dependencies, the
> people committing them don't run precommit before doing so. We know this from
> the jenkins fails that happen.
> 3. really, for a "packaging" change like dependencies nightly-smoke is the
> one to run to get best verification.
> We should do the same for other problematic targets, I know i opened an issue
> for the jtidy one... that is still unresolved.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
