[
https://issues.apache.org/jira/browse/LUCENE-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181971#comment-14181971
]
David Smiley commented on LUCENE-6022:
--------------------------------------
+1 yeah the patch is good.
This class got me curious what it's for. Despite its name and what it's
javadocs claim, it doesn't appear to have anything to do with DocValues, even
if some DocValues code might in turn use it. It looks remarkably like
FilteredDocIdSet but instead of wrapping another DocIdSet, it wraps a Bits.
I've seem somewhat similar classes actually. I propose that it be renamed to
not have DocValues in its name. But to what? BitsFilteredDocIdSet is already
taken. It needn't have Bits in the name; that could be just a feature
(optional Bits filter).
_gotta go now..._
> DocValuesDocIdSet: check deleted docs before doc values
> -------------------------------------------------------
>
> Key: LUCENE-6022
> URL: https://issues.apache.org/jira/browse/LUCENE-6022
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Trivial
> Fix For: 5.0
>
> Attachments: LUCENE-6022.patch
>
>
> When live documents are not null, DocValuesDocIdSet checks if doc values
> match the document before the live docs. Given that checking if doc values
> match could involve a heavy computation (eg. geo distance) and that the
> default codec has live docs in memory but doc values on disk, I think it
> makes more sense to check live docs first?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
