[ 
https://issues.apache.org/jira/browse/LUCENE-6023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14183764#comment-14183764
 ] 

Robert Muir commented on LUCENE-6023:
-------------------------------------

tf/idf similarity exposes its own api, which is meant for extension. Thats why 
the low level methods are final, otherwise the API would be inconsistent and 
unsafe.

If you want to change how norms are encoded and so on, that is really expert. 
extend similarity directly.

> Remove "final" modifier from four methods of TFIDFSimilarity class to make 
> them overridable.
> --------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-6023
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6023
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/query/scoring
>    Affects Versions: 4.2.1
>            Reporter: Hafiz M Hamid
>              Labels: similarity
>             Fix For: 4.2.1
>
>
> The TFIDFSimilarity has the following four of its public methods marked 
> "final" which is keeping us from overriding these methods. Apparently there 
> doesn't seem to be an obvious reason for keeping these methods 
> non-overridable.
> Here are the four methods:
> computeNorm()
> computeWeight()
> exactSimScorer()
> sloppySimScorer()



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to