[
https://issues.apache.org/jira/browse/LUCENE-6025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14186267#comment-14186267
]
Robert Muir commented on LUCENE-6025:
-------------------------------------
Patch is great, I really like the simplification of SparseBitSet.nextSetBit too.
Shouldn't DocIDSet.build() specify BitDocIDSet as return value? This would fix
the compile error in join module with the current patch, and give better type
safety... which this area of the code sorely needs.
for the join module we should maybe try to fix the type safety bugs with
something like:
{code}
abstract class ParentsFilter extends Filter {
// we just narrow the return type to one that will actually friggin work.
@Override abstract BitDocIdSet getDocIDSet(...);
}
{code}
BitSetCachingWrapperFilter would extend that one instead, but wrap any Filter.
> Add BitSet.prevSetBit
> ---------------------
>
> Key: LUCENE-6025
> URL: https://issues.apache.org/jira/browse/LUCENE-6025
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Minor
> Attachments: LUCENE-6025.patch
>
>
> This would allow the join module to work with any BitSet as opposed to only
> FixedBitSet.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
