Hoss Man created SOLR-6682:
------------------------------

             Summary: EnumField + StatsComponent gives bad toString() for 
min/max, probably doesn't work in distributed search ... definitely needs more 
tests
                 Key: SOLR-6682
                 URL: https://issues.apache.org/jira/browse/SOLR-6682
             Project: Solr
          Issue Type: Bug
            Reporter: Hoss Man


when EnumField was added, support was included in StatsComponent for it (via 
the EnumStatsValues) but it doesn't seem to have ever had any tests written for 
it.

doing some quick manual testing, it seems like the min/max values just wind up 
being the "toString()" value of the EnumFieldValue, so you get a response like 
this...

{code}
<lst name="stats">
  <lst name="stats_fields">
    <lst name="hoss">
      <str name="min">org.apache.solr.common.EnumFieldValue:Low</str>
      <str name="max">org.apache.solr.common.EnumFieldValue:High</str>
      <long name="count">2</long>
      <long name="missing">0</long>
      <lst name="facets"/></lst>
    </lst>
  </lst>
{code}

we should fix this to return just the stat label, and update the various 
StatsComponent tests to also cover enums & make sure it works as well as 
strings & numbers.

notably: i'm fairly certain this EnumStatsValues class won't work at all in a 
distributed (stats) request.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to