[
https://issues.apache.org/jira/browse/SOLR-6597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anshum Gupta resolved SOLR-6597.
--------------------------------
Resolution: Fixed
> SolrIndexConfig parameter in SolrIndexSearcher constructor is not used
> ----------------------------------------------------------------------
>
> Key: SOLR-6597
> URL: https://issues.apache.org/jira/browse/SOLR-6597
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 4.10
> Reporter: Anshum Gupta
> Assignee: Anshum Gupta
> Fix For: 5.0
>
> Attachments: SOLR-6597.patch
>
>
> The following constructor of SolrIndexSearcher doesn't use 'config'.
> {code:title=SolrIndexSearcher}
> public SolrIndexSearcher(SolrCore core, String path, IndexSchema schema,
> SolrIndexConfig config, String name, DirectoryReader r, boolean closeReader,
> boolean enableCache, boolean reserveDirectory, DirectoryFactory
> directoryFactory)
> {code}
> It doesn't make sense to pass in the SolrIndexConfig when we're passing in
> the DirectoryReader (and asserting that it's never null). Prior to
> LUCENE-5666, when 'r' was null, the config was used to get a reader but not
> any more.
> I'll just remove the param from the constructor and remove it from all places
> that calls this version of the constructor.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
