[ 
https://issues.apache.org/jira/browse/LUCENE-2834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12975251#action_12975251
 ] 

Robert Muir commented on LUCENE-2834:
-------------------------------------

{quote}
One thing: I don't like the empty catch blocks /* cannot happen */. Even if 
this is the case, please throw at least a RuntimException. Some user may stiull 
use a broken JVM where the charsets.jar file is lost  (ok, that should not 
happen, but I like it more to have that).
{quote}

Your comment makes no sense, unlike the MD5 case, UTF-8 support is guaranteed 
in all versions of java.

"Every implementation of the Java platform is required to support the following 
standard charsets.
...
UTF-8   Eight-bit UCS Transformation Format"

I think you are somehow confused about things that are mandatory to be 
supported in java,
and things that only *happen to exist in all sun jvms*.


> don't spawn thread statically in FSDirectory on Mac OS X
> --------------------------------------------------------
>
>                 Key: LUCENE-2834
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2834
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Robert Muir
>             Fix For: 2.9.5, 3.0.4, 3.1, 4.0
>
>         Attachments: LUCENE-2834.patch, LUCENE-2834.patch
>
>
> on the Mac, creating the digester starts up a PKCS11 thread.
> I do not think threads should be created statically (I have this same issue 
> with TimeLimitedCollector and also FilterManager).
> Uwe discussed removing this md5 digester, I don't care if we remove it or 
> not, just as long as it doesn't create a thread,
> and just as long as it doesn't use the system default locale.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to