[
https://issues.apache.org/jira/browse/SOLR-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14194869#comment-14194869
]
David Smiley commented on SOLR-4656:
------------------------------------
I saw the results of the modifications here during my work on SOLR-6680. It's
not clear to me there needed to be new parameters. Shouldn't the field value
lengths be accumulated, approaching maxAnalyzedChars and then exit at that
point? And furthermore, shouldn't this field value loop exit early once it
sees {{fragTexts.size() >= numFragments}} (i.e. hl.snippets is reached) ?
> Add hl.maxMultiValuedToExamine to limit the number of multiValued entries
> examined while highlighting
> -----------------------------------------------------------------------------------------------------
>
> Key: SOLR-4656
> URL: https://issues.apache.org/jira/browse/SOLR-4656
> Project: Solr
> Issue Type: Improvement
> Components: highlighter
> Affects Versions: 4.3, Trunk
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Minor
> Fix For: 4.3, Trunk
>
> Attachments: SOLR-4656-4x.patch, SOLR-4656-4x.patch,
> SOLR-4656-trunk.patch, SOLR-4656.patch
>
>
> I'm looking at an admittedly pathological case of many, many entries in a
> multiValued field, and trying to implement a way to limit the number
> examined, analogous to maxAnalyzedChars, see the patch.
> Along the way, I noticed that we do what looks like unnecessary copying of
> the fields to be examined. We call Document.getFields, which copies all of
> the fields and values to the returned array. Then we copy all of those to
> another array, converting them to Strings. Then we actually examine them. a>
> this doesn't seem very efficient and b> reduces the benefit from limiting the
> number of mv values examined.
> So the attached does two things:
> 1> attempts to fix this
> 2> implements hl.maxMultiValuedToExamine
> I'd _really_ love it if someone who knows the highlighting code takes a peek
> at the fix to see if I've messed things up, the changes are actually pretty
> minimal.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
