[ 
https://issues.apache.org/jira/browse/LUCENE-6050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14203321#comment-14203321
 ] 

Arcadius Ahouansou commented on LUCENE-6050:
--------------------------------------------

Hello [~janechang] .
Thank you very much for the patch,
The initial description of this issue was rather confusing, so I have updated 
it.

I have checked the patch and your implementation is 
{code}lookup(CharSequence key, Set<BytesRef> contexts, int num, boolean 
allTermsRequired, boolean doHighlight, boolean allContextsRequired){code} which 
was accidentally mentioned in the initial issue description. 

In term of flexibility, there are many ways to solve this issue and we could 
have something like:
{code}lookup(CharSequence key, Set<BytesRef> contexts, Set<BytesRef> 
requiredContexts, int num, boolean allTermsRequired, boolean doHighlight){code} 
or 
{code}lookup(CharSequence key, Map<BytesRef, BooleanClause.Occur> contextInfo, 
int num, boolean allTermsRequired, boolean doHighlight){code}
or
{code}lookup(CharSequence key, Map<BooleanClause.Occur, Set<BytesRef>> 
contextInfo, int num, boolean allTermsRequired, boolean doHighlight){code}
or ...?
What do you think [~janechang] and [~mikemccand] would be the cleanest and most 
flexible way to do this?

Thanks.

> Add possibility to specify SHOUD or MUST for each context for 
> AnalyzingInfixSuggester.loockup()
> -----------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-6050
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6050
>             Project: Lucene - Core
>          Issue Type: Bug
>    Affects Versions: 4.10.2
>            Reporter: Arcadius Ahouansou
>            Priority: Minor
>         Attachments: LUCENE-6050.patch
>
>
> Currently as shown at 
> https://github.com/apache/lucene-solr/blob/lucene_solr_4_9_0/lucene/suggest/src/java/org/apache/lucene/search/suggest/analyzing/AnalyzingInfixSuggester.java#L362
>   , we have:
> {code}
> lookup(CharSequence key, Set<BytesRef> contexts, int num, boolean 
> allTermsRequired, boolean doHighlight)
> {code}
> and *SHOULD* is being applied to all contexts.
> We need the ability to specify whether it's a *SHOULD* or a *MUST* on each 
> individual context.
> Thanks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to