[
https://issues.apache.org/jira/browse/LUCENE-5953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler resolved LUCENE-5953.
-----------------------------------
Resolution: Fixed
I committed this. We may think about making
I also noticed that (at least on my windows machine), Snapshooter sometimes
fails with a crazy NoSuchFileException when trying to *write* a snapshot. To me
it looks like a multi-threading issue, which may not be related to the changes
here. We will see on jenkins.
Nevertheless, Snapshooter should be removed (as far as I understand from the
comments in the code because it is no longer used).
> Make LockFactory final on Directory
> -----------------------------------
>
> Key: LUCENE-5953
> URL: https://issues.apache.org/jira/browse/LUCENE-5953
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/store
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 5.0, Trunk
>
> Attachments: LUCENE-5953.patch, LUCENE-5953.patch, LUCENE-5953.patch,
> LUCENE-5953.patch, LUCENE-5953.patch
>
>
> We should remove the setters for the LockFactory from Directory and make the
> field final. It is a bug to change the LockFactory after creating a
> directory, because you may break locking (if locks are currently held).
> The LockFactory should be passed on ctor only.
> The other suggestion: Should LockFactory have a directory at all? We moved
> away from having the lock separately from the index directory. This is no
> longer a supported configuration (since approx Lucene 2.9 or 3.0). I would
> like to remove the directory from LockFactory and make it part of the
> Directory only.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
