[
https://issues.apache.org/jira/browse/LUCENE-5953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14204120#comment-14204120
]
ASF subversion and git services commented on LUCENE-5953:
---------------------------------------------------------
Commit 1637744 from [~thetaphi] in branch 'dev/branches/branch_5x'
[ https://svn.apache.org/r1637744 ]
Merged revision(s) 1637743 from lucene/dev/trunk:
LUCENE-5953: Revert changes to SnapShooter, just remove useless locking. The
tests now pass more often, because snapshot directory does not disappear
suddenly (its created explicitely before file copying
> Refactor LockFactory usage in Directory
> ---------------------------------------
>
> Key: LUCENE-5953
> URL: https://issues.apache.org/jira/browse/LUCENE-5953
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/store
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 5.0, Trunk
>
> Attachments: LUCENE-5953.patch, LUCENE-5953.patch, LUCENE-5953.patch,
> LUCENE-5953.patch, LUCENE-5953.patch
>
>
> We should remove the setters for the LockFactory from Directory and make the
> field final. It is a bug to change the LockFactory after creating a
> directory, because you may break locking (if locks are currently held).
> The LockFactory should be passed on ctor only.
> The other suggestion: Should LockFactory have a directory at all? We moved
> away from having the lock separately from the index directory. This is no
> longer a supported configuration (since approx Lucene 2.9 or 3.0). I would
> like to remove the directory from LockFactory and make it part of the
> Directory only.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
