[
https://issues.apache.org/jira/browse/LUCENE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-6055:
-------------------------------
Attachment: LUCENE-6055.patch
Patch fixes PA.clone(). I added a test to TestAttributeSource as I didn't find
a more suitable place. But if someone can suggest one, I will gladly move it.
Other than that, I think it's ready.
> PayloadAttribute.clone() should deep clone its BytesRef
> -------------------------------------------------------
>
> Key: LUCENE-6055
> URL: https://issues.apache.org/jira/browse/LUCENE-6055
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/index
> Reporter: Shai Erera
> Assignee: Shai Erera
> Fix For: Trunk, 5.x
>
> Attachments: LUCENE-6055.patch
>
>
> PayloadAttribute.clone() does a shallow clone, unlike e.g. CharTermAttribute.
> Attributes should deep clone, otherwise capturing state isn't correct. In
> addition, both PA's and CTA's .clone() falsely documents that they do shallow
> cloning on purposes, so need to fix that too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
