[
https://issues.apache.org/jira/browse/LUCENE-5929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless updated LUCENE-5929:
---------------------------------------
Attachment: LUCENE-5929.patch
Thanks Julie, the patch looks good! Do we really need the added join dep in
benchmark?
I updated the patch based on recent trunk changes, attached.
However, "ant clean test" from lucene subdir fails, because ant doesn't build
join before building highlight ... not sure yet where to fix this. If you
manually "ant jar" from inside "lucene/join" first, it works.
> Standard highlighting doesn't work for ToParentBlockJoinQuery
> -------------------------------------------------------------
>
> Key: LUCENE-5929
> URL: https://issues.apache.org/jira/browse/LUCENE-5929
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/highlighter
> Reporter: Julie Tibshirani
> Assignee: Michael McCandless
> Priority: Critical
> Attachments: HighligherTest.patch, LUCENE-5929.patch,
> LUCENE-5929.patch
>
>
> Because WeightedSpanTermExtractor#extract doesn't check for
> ToParentBlockJoinQuery, the Highlighter class fails to produce highlights for
> this type of query.
> At first it may seem like there's no issue, because ToParentBlockJoinQuery
> only returns parent documents, while the highlighting applies to children.
> But if a client can directly supply the text from child documents (as
> elasticsearch does if _source is enabled), then highlighting will
> unexpectedly fail.
> A test case that triggers the bug is attached. The same issue exists for
> ToChildBlockJoinQuery.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
