[ 
https://issues.apache.org/jira/browse/LUCENE-5929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14209915#comment-14209915
 ] 

ASF subversion and git services commented on LUCENE-5929:
---------------------------------------------------------

Commit 1639372 from [~mikemccand] in branch 'dev/branches/branch_5x'
[ https://svn.apache.org/r1639372 ]

LUCENE-5929: highlight terms from block join queries too

> Standard highlighting doesn't work for ToParentBlockJoinQuery
> -------------------------------------------------------------
>
>                 Key: LUCENE-5929
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5929
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/highlighter
>            Reporter: Julie Tibshirani
>            Assignee: Michael McCandless
>            Priority: Critical
>             Fix For: 5.0, Trunk
>
>         Attachments: HighligherTest.patch, LUCENE-5929.patch, 
> LUCENE-5929.patch
>
>
> Because WeightedSpanTermExtractor#extract doesn't check for 
> ToParentBlockJoinQuery, the Highlighter class fails to produce highlights for 
> this type of query.
> At first it may seem like there's no issue, because ToParentBlockJoinQuery 
> only returns parent documents, while the highlighting applies to children. 
> But if a client can directly supply the text from child documents (as 
> elasticsearch does if _source is enabled), then highlighting will 
> unexpectedly fail.
> A test case that triggers the bug is attached. The same issue exists for 
> ToChildBlockJoinQuery.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to