[
https://issues.apache.org/jira/browse/LUCENE-6060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14216453#comment-14216453
]
Michael McCandless commented on LUCENE-6060:
--------------------------------------------
Well, Solr still has the unlockOnStartup; I wasn't sure what to do with that so
I left it for now and opened SOLR-6737.
Most Lucene apps shouldn't be using the legacy SimpleFSLockFactory, and if they
are 1) they must already be dealing with the "remove lock on startup", 2) if
they are doing so via IndexWriter.unlock, they will see the
deprecation/compilation error on upgrade, dig in CHANGES, find this issue, and
then have to do their own scary things: I think this is healthy.
I don't really like the deleteOnExit method.
> Remove IndexWriter.unLock
> -------------------------
>
> Key: LUCENE-6060
> URL: https://issues.apache.org/jira/browse/LUCENE-6060
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/index
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 4.10, 5.0, Trunk
>
> Attachments: LUCENE-6060.patch
>
>
> This method used to be necessary, when our locking impls were buggy, but it's
> a godawful dangerous method: it invites index corruption.
> I think we should remove it.
> Apps that for some scary reason really need it can do their own thing...
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
