[
https://issues.apache.org/jira/browse/SOLR-4509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14226858#comment-14226858
]
Mark Miller commented on SOLR-4509:
-----------------------------------
bq. given that any check is imperfect
Yeah, I was more referring to the fact that the whole thing kind of seems like
a bad bug to me - except that in pure http, a retry is often fine and I guess
keeps it from being a flat out buggy situation. If you turn off retries, it
does seem like a buggy implementation, though a tough one to solve generally
for HttpClient I guess. Even with Solr, I'm not super happy you have to line up
the server and client idle setting reasonably, but it appears the best we can
do.
I guess in my mind, a non imperfect implementation would not have this built in
'random race condition fail'.
> Disable HttpClient stale check for performance and fewer spurious connection
> errors.
> ------------------------------------------------------------------------------------
>
> Key: SOLR-4509
> URL: https://issues.apache.org/jira/browse/SOLR-4509
> Project: Solr
> Issue Type: Improvement
> Components: search
> Environment: 5 node SmartOS cluster (all nodes living in same global
> zone - i.e. same physical machine)
> Reporter: Ryan Zezeski
> Assignee: Mark Miller
> Priority: Minor
> Fix For: 5.0, Trunk
>
> Attachments: IsStaleTime.java, SOLR-4509-4_4_0.patch,
> SOLR-4509.patch, SOLR-4509.patch, SOLR-4509.patch, SOLR-4509.patch,
> baremetal-stale-nostale-med-latency.dat,
> baremetal-stale-nostale-med-latency.svg,
> baremetal-stale-nostale-throughput.dat, baremetal-stale-nostale-throughput.svg
>
>
> By disabling the Apache HTTP Client stale check I've witnessed a 2-4x
> increase in throughput and reduction of over 100ms. This patch was made in
> the context of a project I'm leading, called Yokozuna, which relies on
> distributed search.
> Here's the patch on Yokozuna: https://github.com/rzezeski/yokozuna/pull/26
> Here's a write-up I did on my findings:
> http://www.zinascii.com/2013/solr-distributed-search-and-the-stale-check.html
> I'm happy to answer any questions or make changes to the patch to make it
> acceptable.
> ReviewBoard: https://reviews.apache.org/r/28393/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
