[
https://issues.apache.org/jira/browse/SOLR-6793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14227686#comment-14227686
]
Ramkumar Aiyengar commented on SOLR-6793:
-----------------------------------------
bq. I'm not sure - the tempSnapPuller is kept around for stats calls, and I'm
worried about using it after destroy is called. Has a bad smell.
Ah. Yeah, this entire stats business is actually the only thing which makes me
nervous about removing temp as well. {{tempSnapPuller}} is assigned to
{{snapPuller}} at the end, so you won't be calling it on a destroyed object,
but I need to figure out what the intent of the stats is -- is it for the last
{{doFetch}} call done by replicate, or something else? If it's the former,
what's {{snapPuller}} doing?
> ReplicationHandler does not destroy all of it's created SnapPullers
> -------------------------------------------------------------------
>
> Key: SOLR-6793
> URL: https://issues.apache.org/jira/browse/SOLR-6793
> Project: Solr
> Issue Type: Bug
> Reporter: Mark Miller
> Assignee: Mark Miller
> Priority: Minor
> Fix For: 5.0, Trunk
>
> Attachments: SOLR-6793.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
