[
https://issues.apache.org/jira/browse/LUCENE-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14229679#comment-14229679
]
Michael McCandless commented on LUCENE-6075:
--------------------------------------------
bq. I wonder if it makes sense to have a "sanity check" upper bound to rate
limiting - as sleeping for 25 days is most likely not the intended behaviour..
25 days is clearly rather silly ... but I'm not sure we should add such checks
at this low level. Where would you draw the line?
> SimpleRateLimiter cast overflow results in Thread.sleep exception
> -----------------------------------------------------------------
>
> Key: LUCENE-6075
> URL: https://issues.apache.org/jira/browse/LUCENE-6075
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/store
> Reporter: Boaz Leskes
> Assignee: Michael McCandless
> Fix For: 4.10.3, Trunk, 5.x
>
> Attachments: LUCENE-6075.patch
>
>
> SimpleRateLimiter.pause() uses an uncheck cast of longs to ints:
> Thread.sleep((int) (pauseNS/1000000), (int) (pauseNS % 1000000));
> Although we check that pauseNS is positive, however if it's large enough the
> cast to int produces a negative value, causing Thread.sleep to throw an
> exception.
> We should protect for it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
