On Mon, Dec 1, 2014 at 12:24 PM, Chris Hostetter <[email protected]> wrote: > > right, i guess a better way to restate my question -- now that i > understand better what is being "mocked" -- is to ask: > > Shouldn't there an easy way (ie: sys prop?) for end users, who may > primarily be interested in testing lucene/solr on *their* OS with *their* > filesystem, to tell the test framework to skip all mocking of the > filesystem? > > so if someone wants to try out a patch, or do regression testing before > upgrading, and wants to beast all the lucene/solr tests on their > fs/os/hardware stack can force all X runs to use their *real* filesystem > w/o any mocking? >
I dont think so. Such a thing is unrelated to this change. We have had "act like windows" and other filesystem-mocking code in our tests forever (MockDirectoryWrapper), and we add lots of asserting-wrappers and other mocks around the codec API and other key places during tests. This change just allows us to mock filesystem behavior underneath the Directory api, and its usable for testing things against filesystem operations that don't go thru the directory api too. The purpose of our tests is to ensure the code is correct and nothing more. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
