[
https://issues.apache.org/jira/browse/LUCENE-6085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14231726#comment-14231726
]
ASF subversion and git services commented on LUCENE-6085:
---------------------------------------------------------
Commit 1642943 from [~rcmuir] in branch 'dev/branches/branch_5x'
[ https://svn.apache.org/r1642943 ]
LUCENE-6085: add back SI.attributes
> Add back SI.attributes (safely)
> -------------------------------
>
> Key: LUCENE-6085
> URL: https://issues.apache.org/jira/browse/LUCENE-6085
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
> Fix For: 5.0, Trunk
>
> Attachments: LUCENE-6085.patch
>
>
> We removed this for two reasons:
> * nothing was using it
> * the map is "unsafe" if a codec tried to write to it during in-place dv
> update.
> But Adrien has a real use case (LUCENE-5914), and I think we can just add
> some safety for the updates case (e.g. if the map is unmodifiable then the
> trap will not exist, any put() will throw exception). In general, we should
> have more safety in SI anyway (diagnostics map, too).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
