[
https://issues.apache.org/jira/browse/SOLR-6625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gregory Chanan updated SOLR-6625:
---------------------------------
Attachment: SOLR-6625.patch
Here's a new version of the patch, along the lines of what Per and I discussed
above.
Changes from previous patch:
- Now works across HttpClient invocations, not just in HttpSolrServer. So raw
HttpClient calls from the SolrDispatchFilter, ConcurrentUpdateSolrServer,
SolrCLI are handled as well. There are unit tests for all the above except
SolrCLI (for which I couldn't find a general test for)
- Can be configured similar to the ZKCredentials. So the server side is
configured via solr.xml, client side is configured via system properties.
- We now pass a SolrRequest to the callback, to match the semantics of
SOLR-4470. So it should be easy to incorporate SOLR-4470 at a later date.
- Because we pass a SolrRequest to the callback, for the raw httpclient calls
we generate a SolrRequest that matches the underlying call. These raw calls
should probably use HttpSolrServer anyway -- this is a step in that direction.
This changed required adding support for more http methods, since the forwarded
requests can send HEAD and DELETE, for example.
> HttpClient callback in HttpSolrServer
> -------------------------------------
>
> Key: SOLR-6625
> URL: https://issues.apache.org/jira/browse/SOLR-6625
> Project: Solr
> Issue Type: Improvement
> Components: SolrJ
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Minor
> Attachments: SOLR-6625.patch, SOLR-6625.patch, SOLR-6625.patch
>
>
> Some of our setups use Solr in a SPNego/kerberos setup (we've done this by
> adding our own filters to the web.xml). We have an issue in that SPNego
> requires a negotiation step, but some HttpSolrServer requests are not
> repeatable, notably the PUT/POST requests. So, what happens is,
> HttpSolrServer sends the requests, the server responds with a negotiation
> request, and the request fails because the request is not repeatable. We've
> modified our code to send a repeatable request beforehand in these cases.
> It would be nicer if HttpSolrServer provided a pre/post callback when it was
> making an httpclient request. This would allow administrators to make
> changes to the request for authentication purposes, and would allow users to
> make per-request changes to the httpclient calls (i.e. modify httpclient
> requestconfig to modify the timeout on a per-request basis).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
