[ https://issues.apache.org/jira/browse/LUCENE-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14238681#comment-14238681 ]
Robert Muir commented on LUCENE-4335: ------------------------------------- Well the easiest way would be to speed up the current regeneration? It currently takes 47 seconds. But honestly I don't have a lot of confidence this stuff can be that much faster faster. Its not like we are making it intentionally ineffecient. Look at what some of the regenerators are doing... packing large FSTs of tokenization models, minimizing large jflex DFAs, etc. > Builds should regenerate all generated sources > ---------------------------------------------- > > Key: LUCENE-4335 > URL: https://issues.apache.org/jira/browse/LUCENE-4335 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Michael McCandless > Assignee: Michael McCandless > Attachments: LUCENE-4335.patch, LUCENE-4335.patch, LUCENE-4335.patch > > > We have more and more sources that are generated programmatically (query > parsers, fuzzy levN tables from Moman, packed ints specialized decoders, > etc.), and it's dangerous because developers may directly edit the generated > sources and forget to edit the meta-source. It's happened to me several > times ... most recently just after landing the BlockPostingsFormat branch. > I think we should re-gen all of these in our builds and fail the build if > this creates a difference. I know some generators (eg JavaCC) embed > timestamps and so always create mods ... we can leave them out of this for > starters (or maybe post-process the sources to remove the timestamps) ... -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org