[
https://issues.apache.org/jira/browse/SOLR-6840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14246302#comment-14246302
]
Erick Erickson commented on SOLR-6840:
--------------------------------------
OK, we need to decide how we'll approach persistence in particular.
1> There's no persist=false in the new solr.xml, ConfigSolrXml.isPersistent
always returns true. Or I'm missing something again. 75 tests fail since they
try to write out to the solr test files tree and the framework (rightly) barfs
(see <2> below). This assumes that I do the trick in <2> of my _previous_
comment. Any suggestions?
2> You can get around <1> by copying all the config files to a temp dir and
making solr_home point there. For many, many tests. This means that a zillion
files get copied all over the place. This fixes 75 test failures.
So, in general what's the story with dealing with persistence in the new
format, particularly in the test world? I really don't want to re-introduce the
whole horrible persistence stuff.... [~romseygeek] I'd be particularly
interested in your take. Is there any real reason for
ConfigSolrXml.isPersistent to return true?
And also note that there are a bunch of places that really need some attention.
I blindly removed all the <cores... tags. There's more than one place where
that means the in-test solr.xml file (as a string) looks like <solr></solr>,
which is useless and ought to be dealt with one-by-one.
> Remove legacy solr.xml mode
> ---------------------------
>
> Key: SOLR-6840
> URL: https://issues.apache.org/jira/browse/SOLR-6840
> Project: Solr
> Issue Type: Task
> Reporter: Steve Rowe
> Assignee: Erick Erickson
> Priority: Blocker
> Fix For: 5.0
>
> Attachments: SOLR-6840.patch
>
>
> On the [Solr Cores and solr.xml
> page|https://cwiki.apache.org/confluence/display/solr/Solr+Cores+and+solr.xml],
> the Solr Reference Guide says:
> {quote}
> Starting in Solr 4.3, Solr will maintain two distinct formats for
> {{solr.xml}}, the _legacy_ and _discovery_ modes. The former is the format we
> have become accustomed to in which all of the cores one wishes to define in a
> Solr instance are defined in {{solr.xml}} in
> {{<cores><core/>...<core/></cores>}} tags. This format will continue to be
> supported through the entire 4.x code line.
> As of Solr 5.0 this form of solr.xml will no longer be supported. Instead
> Solr will support _core discovery_. [...]
> The new "core discovery mode" structure for solr.xml will become mandatory as
> of Solr 5.0, see: Format of solr.xml.
> {quote}
> AFAICT, nothing has been done to remove legacy {{solr.xml}} mode from 5.0 or
> trunk.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
