[ 
https://issues.apache.org/jira/browse/SOLR-6886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257267#comment-14257267
 ] 

ASF GitHub Bot commented on SOLR-6886:
--------------------------------------

GitHub user cpoerschke opened a pull request:

    https://github.com/apache/lucene-solr/pull/116

    SOLR-6886: Grouping.java tweaks

    for https://issues.apache.org/jira/i#browse/SOLR-6886 ticket

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bloomberg/lucene-solr trunk-Grouping-tweaks

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucene-solr/pull/116.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #116
    
----
commit 5361b06bd1eb7389566f8604a21d433d748d6590
Author: Christine Poerschke <[email protected]>
Date:   2014-11-18T15:27:06Z

    solr: Grouping.java tweaks
    
    remove redundant size>0 check, add missing DelegatingCollector.finish calls

----


> Grouping.java tweaks
> --------------------
>
>                 Key: SOLR-6886
>                 URL: https://issues.apache.org/jira/browse/SOLR-6886
>             Project: Solr
>          Issue Type: Wish
>            Reporter: Christine Poerschke
>            Priority: Minor
>
> There's a size>0 check which seems to be redundant and some 
> DelegatingCollector.finish calls seem to be missing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to