[ 
https://issues.apache.org/jira/browse/SOLR-6797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ishan Chattopadhyaya updated SOLR-6797:
---------------------------------------
    Attachment: SOLR-6797.patch

Here's a patch that addresses some of these issues. Please suggest if I'm on 
the right track.

Few things that are yet to do:
* Example/default schema to reflect 1m of maxDistErr and not depend on degrees.
* Wasn't sure what use a Units class would have. Although I didn't understand 
its need, I felt something similar should sit in Spatial4j instead of Solr.
* Need to write tests for all these conversions done to "d", sphere radius, 
SpatialArgs.distErr, maxDistErr.

> Add score=degrees|kilometers|miles for AbstractSpatialFieldType
> ---------------------------------------------------------------
>
>                 Key: SOLR-6797
>                 URL: https://issues.apache.org/jira/browse/SOLR-6797
>             Project: Solr
>          Issue Type: Improvement
>          Components: spatial
>            Reporter: David Smiley
>         Attachments: SOLR-6797.patch, SOLR-6797.patch, SOLR-6797.patch, 
> SOLR-6797.patch, SOLR-6797.patch
>
>
> Annoyingly, the units="degrees" attribute is required for fields extending 
> AbstractSpatialFieldType (e.g. RPT, BBox).  And it doesn't really have any 
> effect.  I propose the following:
> * Simply drop the attribute; ignore it if someone sets it to "degrees" (for 
> back-compat).
> * When using score="distance", or score=area or area2D (as seen in BBoxField) 
> then use kilometers if geo=true, otherwise degrees.
> * Add support for score=degrees|kilometers|miles|degrees



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to