[
https://issues.apache.org/jira/browse/SOLR-6902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14261414#comment-14261414
]
ASF GitHub Bot commented on SOLR-6902:
--------------------------------------
GitHub user andyetitmoves opened a pull request:
https://github.com/apache/lucene-solr/pull/121
Use JUnit rules instead of inheritance with distributed Solr tests to allow
for multiple tests without the same class
Patch for SOLR-6902
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bloomberg/lucene-solr trunk-shard-junit-rule
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/121.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #121
----
commit 02d678044a9f399a6bdf63e9a977d6e760a0a1bf
Author: Ramkumar Aiyengar <[email protected]>
Date: 2014-12-30T14:39:23Z
Use JUnit rules instead of inheritance with distributed tests to allow for
multiple tests without the same class.
----
> Use JUnit rules instead of inheritance with distributed Solr tests to allow
> for multiple tests without the same class
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-6902
> URL: https://issues.apache.org/jira/browse/SOLR-6902
> Project: Solr
> Issue Type: Improvement
> Components: Tests
> Reporter: Ramkumar Aiyengar
> Priority: Minor
>
> Finally got annoyed enough with too many things being clubbed into one test
> method in all distributed Solr tests (anything inheriting from
> {{BaseDistributedSearchTestCase}} and currently implementing {{doTest}})..
> This just lays the groundwork really for allowing multiple test methods
> within the same class, and doesn't split tests as yet or flatten the
> inheritance hierarchy (when abused for doing multiple tests), as this touches
> a lot of files by itself. For that reason, the sooner this is picked up the
> better..
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
