[ 
https://issues.apache.org/jira/browse/LUCENE-6154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14262529#comment-14262529
 ] 

Michael McCandless commented on LUCENE-6154:
--------------------------------------------

OK I agree: this method is dangerous, so we should remove it.  ES can do this 
on its own.

Fortunately it has not been released yet: I added it in LUCENE-6099.

> nuke FilterDirectory.unwrap or make package-private
> ---------------------------------------------------
>
>                 Key: LUCENE-6154
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6154
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>
> As Uwe points out, this is dangerous. The only thing using it is its test: 
> TestFilterDirectory.testUnwrap() and IOUtils.spins().
> If this method is implemented in some other way, we could remove it. 
> otherwise maybe it can be package-private.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to