[
https://issues.apache.org/jira/browse/SOLR-5616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson updated SOLR-5616:
---------------------------------
Attachment: SOLR-5616.patch
The same patch, except it doesn't re-arrange imports.
Nice catch, changing the QueryComponent when you add a new component sure is
ugly.
My only question is whether the sense of the test in QueryComponent is
preserved or whether this line (479):
{code}
if (rb.isNeedDocList()) {
{code}
should be
{code}
if (rb.isNeedDocList() || rb.isDebug()) {
{code}
The test over in DebugComponent isn't quite the same:
{code}
if(rb.isDebugTrack() && rb.isDistrib) {
{code}
> Make grouping code use response builder needDocList
> ---------------------------------------------------
>
> Key: SOLR-5616
> URL: https://issues.apache.org/jira/browse/SOLR-5616
> Project: Solr
> Issue Type: Bug
> Reporter: Steven Bower
> Assignee: Erick Erickson
> Attachments: SOLR-5616.patch, SOLR-5616.patch
>
>
> Right now the grouping code does this to check if it needs to generate a
> docList for grouped results:
> {code}
> if (rb.doHighlights || rb.isDebug() || params.getBool(MoreLikeThisParams.MLT,
> false) ){
> ...
> }
> {code}
> this is ugly because any new component that needs a doclist, from grouped
> results, will need to modify QueryComponent to add a check to this if.
> Ideally this should just use the rb.isNeedDocList() flag...
> Coincidentally this boolean is really never used at for non-grouped results
> it always gets generated..
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
