[ 
https://issues.apache.org/jira/browse/LUCENE-2694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Muir updated LUCENE-2694:
--------------------------------

    Attachment: LUCENE-2694_hack.patch

here's a hack patch (dont think it actually works) just showing what i mean.

I think termsenum should only have seek(TermState).
in the hack-patch, i made the termState() and seekTermState() non-abstract:
the default impl returns a 'SimpleTermState' containing the term bytes and 
saved docFreq and implements seek(TermState) with those bytes.

This is basically what the patch had everywhere anyway as an implementation 
(for many of these, we should use more efficient impls, i fixed this for 
MemoryIndex as an example, but MultiTermsEnum comes to mind).

Also, i don't understand what was going on with setting bytes on the 
DeltaBytesReader with your seek(BytesRef, TermState) before.

If StandardCodec needs to know the shared byte[] prefix or something like that 
to reposition the enum, then it
should put this in its termstate.




> MTQ rewrite + weight/scorer init should be single pass
> ------------------------------------------------------
>
>                 Key: LUCENE-2694
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2694
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Search
>            Reporter: Michael McCandless
>            Assignee: Simon Willnauer
>             Fix For: 4.0
>
>         Attachments: LUCENE-2694-FTE.patch, LUCENE-2694.patch, 
> LUCENE-2694.patch, LUCENE-2694.patch, LUCENE-2694.patch, LUCENE-2694.patch, 
> LUCENE-2694.patch, LUCENE-2694.patch, LUCENE-2694_hack.patch
>
>
> Spinoff of LUCENE-2690 (see the hacked patch on that issue)...
> Once we fix MTQ rewrite to be per-segment, we should take it further and make 
> weight/scorer init also run in the same single pass as rewrite.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to