[ 
https://issues.apache.org/jira/browse/SOLR-6793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14270264#comment-14270264
 ] 

Mark Miller commented on SOLR-6793:
-----------------------------------

bq.  shouldn't the finally block have the same cleanup?

No, the temp close is handled finally in the close hook. If it is changed 
first, then we close the previous one. The temp puller is kept around for stat 
calls as mentioned above currently.

While we might improve some of that, I think this is correct for the current 
code.

> ReplicationHandler does not destroy all of it's created SnapPullers
> -------------------------------------------------------------------
>
>                 Key: SOLR-6793
>                 URL: https://issues.apache.org/jira/browse/SOLR-6793
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>            Priority: Minor
>             Fix For: 5.0, Trunk
>
>         Attachments: SOLR-6793.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to