[ https://issues.apache.org/jira/browse/SOLR-6496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14271776#comment-14271776 ]
Anshum Gupta commented on SOLR-6496: ------------------------------------ You're right. I'll let you get to it as I'm not sure if I'd get time to work on it today. If you're unable to get to it, I'll try handling it over the weekend. About the approaches, ideally, it'd be good to refactor but that certainly is more invasive. With the rc a week away, I'd like it to be less invasive at this point and work on refactoring (and adding tests) separately with the next release. > LBHttpSolrServer should stop server retries after the timeAllowed threshold > is met > ---------------------------------------------------------------------------------- > > Key: SOLR-6496 > URL: https://issues.apache.org/jira/browse/SOLR-6496 > Project: Solr > Issue Type: Bug > Affects Versions: 4.9 > Reporter: Steve Davids > Assignee: Anshum Gupta > Priority: Critical > Fix For: 5.0 > > Attachments: SOLR-6496.patch, SOLR-6496.patch, SOLR-6496.patch, > SOLR-6496.patch, SOLR-6496.patch > > > The LBHttpSolrServer will continue to perform retries for each server it was > given without honoring the timeAllowed request parameter. Once the threshold > has been met, you should no longer perform retries and allow the exception to > bubble up and allow the request to either error out or return partial results > per the shards.tolerant request parameter. > For a little more context on how this is can be extremely problematic please > see the comment here: > https://issues.apache.org/jira/browse/SOLR-5986?focusedCommentId=14100991&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14100991 > (#2) -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org