+1 on CC too. On Sat, Jan 10, 2015 at 3:41 PM Alan Woodward (JIRA) <[email protected]> wrote:
> > [ https://issues.apache.org/jira/browse/SOLR-6954?page= > com.atlassian.jira.plugin.system.issuetabpanels:comment- > tabpanel&focusedCommentId=14272687#comment-14272687 ] > > Alan Woodward commented on SOLR-6954: > ------------------------------------- > > +1. > > I'd suggest we just make shutdown() delegate to close() and deprecate it. > > Might be worth doing the same thing for CoreContainer? > > > Considering changing SolrClient#shutdown to SolrClient#close. > > ------------------------------------------------------------- > > > > Key: SOLR-6954 > > URL: https://issues.apache.org/jira/browse/SOLR-6954 > > Project: Solr > > Issue Type: Improvement > > Reporter: Mark Miller > > Fix For: 5.0, Trunk > > > > > > SolrClient#shutdown is not as odd as SolrServer#shutdown, but as we want > users to release these objects, close is more standard and if we implement > Closeable, tools help point out leaks. > > > > -- > This message was sent by Atlassian JIRA > (v6.3.4#6332) > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
