[ 
https://issues.apache.org/jira/browse/SOLR-6978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277556#comment-14277556
 ] 

Alan Woodward commented on SOLR-6978:
-------------------------------------

Does it need access to the CoreContainer or to something else held within it?  
I'm a bit wary of passing CoreContainer as a dependency here - we already do it 
in too many places IMO when what's really needed is access to a thread pool or 
resource loader.

> Optionally pass CoreContainer to the ShardHandlerFactory 
> ---------------------------------------------------------
>
>                 Key: SOLR-6978
>                 URL: https://issues.apache.org/jira/browse/SOLR-6978
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>            Reporter: Gregg Donovan
>            Priority: Minor
>              Labels: patch
>         Attachments: SOLR-6978.diff
>
>
> We're working on a new ShardHandlerFactory that needs access to the 
> CoreContainer. Attached is a patch that calls a constructor that takes a 
> CoreContainer if it exists. Otherwise, it uses the default constructor.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to