[
https://issues.apache.org/jira/browse/LUCENE-6182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14278867#comment-14278867
]
ASF subversion and git services commented on LUCENE-6182:
---------------------------------------------------------
Commit 1652154 from [~dsmiley] in branch 'dev/trunk'
[ https://svn.apache.org/r1652154 ]
LUCENE-6182: spatial refactor VisitorTemplate.visitScanned needn't be abstract.
And have collectDocs specify BitSet not FixedBitSet. (these are internal APIs)
> Spatial VisitorTemplate.visitScanned needn't be abstract
> --------------------------------------------------------
>
> Key: LUCENE-6182
> URL: https://issues.apache.org/jira/browse/LUCENE-6182
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/spatial
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Minor
> Fix For: 5.x
>
> Attachments: LUCENE-6182.patch
>
>
> visitScanned can be implemented, allowing subclasses to specialize if desired.
> {code:java}
> protected void visitScanned(Cell cell) throws IOException {
> if (queryShape.relate(cell.getShape()).intersects()) {
> if (cell.isLeaf()) {
> visitLeaf(cell);
> } else {
> visit(cell);
> }
> }
> }
> {code}
> Then I can remove Intersect's impl, and remove the one prefix-tree faceting.
> Additionally, I noticed collectDocs(FixBitSet) can be improved to take BitSet
> and call bitSet.or(docsEnum)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
