[
https://issues.apache.org/jira/browse/LUCENE-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14279105#comment-14279105
]
Michael McCandless commented on LUCENE-6185:
--------------------------------------------
bq. Doc ids are already rebased with the doc base of each reader context before
the TopDocs.merge call so I think that would be fine?
Aha! I forgot about that, you're right. So all is good.
bq. And then when we call TopDocs.merge, we provide the top docs instances in
the same order as leaves have been provided to IndexSearcher.search so
tie-breaking by shard id has the same effect as tie-breaking by doc id?
Yes, this is important: earlier shard wins in TopDocs.merge.
> Fix IndexSearcher with threads to not collect documents out of order
> --------------------------------------------------------------------
>
> Key: LUCENE-6185
> URL: https://issues.apache.org/jira/browse/LUCENE-6185
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Blocker
> Fix For: 5.0, Trunk
>
> Attachments: LUCENE-6185.patch
>
>
> When created with an executor, IndexSearcher searches all leaves in a
> different task and eventually merges the results when all tasks are
> completed. However, this merging logic involves a TopFieldCollector which is
> collected out-of-order. I think it should just use TopDocs.merge?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
