OK I missed the SOLR-6937 part . I can revert that. On Sat, Jan 17, 2015 at 11:19 PM, Noble Paul <[email protected]> wrote:
> Sorry for the trouble. > > I committed it because it was a DIH change and not really impacting any of > Solr. However , I can roll it back if required > > > On Sat, Jan 17, 2015 at 1:30 AM, Anshum Gupta <[email protected]> > wrote: > >> I think we can have the changes reverted by Noble as he's the original >> committer. >> >> Noble: Can you please revert the new features that you committed onto the >> 5.0 branch? >> >> On Fri, Jan 16, 2015 at 10:42 AM, Michael McCandless < >> [email protected]> wrote: >> >>> We can just revert the too-dangerous changes? They can wait for 5.1? >>> >>> Mike McCandless >>> >>> http://blog.mikemccandless.com >>> >>> >>> On Fri, Jan 16, 2015 at 1:18 PM, Anshum Gupta <[email protected]> >>> wrote: >>> > All of them seem to have come in while I was sleeping! Until last >>> night, it >>> > was just the CustomAnalyzer that Uwe had notified about. I certainly >>> don't >>> > think SOLR-6937 and SOLR-5147 were fixes for anything but new >>> features. >>> > >>> > The bin/solr (and example) related changes were fixes that seem to be >>> > required for the user to be able to easily use an existing new feature >>> so >>> > I'm fine with that but we(the committer) should try and judge before >>> > committing those too. >>> > >>> > Can we stop committing newer stuff? It really wouldn't help with the >>> > stability of a major release. I am going to strongly oppose any *new* >>> > feature going in now. >>> > >>> > Also, it'd be good to have more appropriate commit messages that >>> clearly >>> > indicate what the commit does. It is generally a good practice but if >>> you >>> > want to commit to a release branch, it's almost mandatory. >>> > >>> > >>> > >>> > >>> > On Fri, Jan 16, 2015 at 5:12 AM, Robert Muir <[email protected]> wrote: >>> >> >>> >> On Tue, Jan 13, 2015 at 9:41 PM, Anshum Gupta <[email protected] >>> > >>> >> wrote: >>> >> > >>> >> > Please only commit important bug fixes to this branch as we're >>> pretty >>> >> > close >>> >> > to cutting an RC and a release. I don't think I'd be able to do the >>> RC >>> >> > as >>> >> > planned on Thursday as we still have a blocker issue in SOLR >>> >> > (SOLR-6640). We >>> >> > should be able to nail that one and get the first RC out early next >>> >> > week. >>> >> >>> >> >>> >> Why are there an endless flurry of new features to this branch? >>> >> >>> >> --------------------------------------------------------------------- >>> >> To unsubscribe, e-mail: [email protected] >>> >> For additional commands, e-mail: [email protected] >>> >> >>> > >>> > >>> > >>> > -- >>> > Anshum Gupta >>> > http://about.me/anshumgupta >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [email protected] >>> For additional commands, e-mail: [email protected] >>> >>> >> >> >> -- >> Anshum Gupta >> http://about.me/anshumgupta >> > > > > -- > ----------------------------------------------------- > Noble Paul > -- ----------------------------------------------------- Noble Paul
