[
https://issues.apache.org/jira/browse/SOLR-6902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14281591#comment-14281591
]
Ramkumar Aiyengar edited comment on SOLR-6902 at 1/17/15 11:37 PM:
-------------------------------------------------------------------
Sorry, about that, I wasn't able to get that far in precommit because of an
another issue on trunk currently due to a possibly broken
{{checkJavadocLinks.py}} which is rejecting some external links.
I fixed that, and now I see the issue. This is certainly a {{checkJavaDocs.py}}
issue. It's munging and cutting the file up, and trying to validate this
fragment which is one, munged, and two, cut up at a wrong place. It seems to be
looking for the code between two h3 or h4's, and trying to match up ul's. It
does try to add an extra ul sometimes, but in this case two ul's are needed.
{noformat}
<ul><pre>public abstract int min</pre>
<dl>
<dt>Default:</dt>
<dd>1</dd>
</dl>
</li>
</ul>
</li>
</ul>
<ul class="blockList">
<li class="blockList"><a name="max--">
<!-- -->
</a>
<ul class="blockListLast">
<li class="blockList">
</ul>
{noformat}
was (Author: andyetitmoves):
Sorry, about that, I wasn't able to get that far in precommit because of an
another issue on trunk currently due to a possibly broken
{{checkJavadocLinks.py}} which is rejecting some external links.
I fixed that, and now I see the issue. This is certainly a {{checkJavaDocs.py}}
issue. It's munging and cutting the file up, and trying to validate this
fragment which is one, munged, and two, cut up at a wrong place. I haven't yet
been able to figure out why that's happening..
{noformat}
<ul><pre>public abstract int min</pre>
<dl>
<dt>Default:</dt>
<dd>1</dd>
</dl>
</li>
</ul>
</li>
</ul>
<ul class="blockList">
<li class="blockList"><a name="max--">
<!-- -->
</a>
<ul class="blockListLast">
<li class="blockList">
</ul>
{noformat}
> Use JUnit rules instead of inheritance with distributed Solr tests to allow
> for multiple tests without the same class
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-6902
> URL: https://issues.apache.org/jira/browse/SOLR-6902
> Project: Solr
> Issue Type: Improvement
> Components: Tests
> Reporter: Ramkumar Aiyengar
> Assignee: Erick Erickson
> Priority: Minor
> Attachments: SOLR-6902.patch, SOLR-6902.patch, SOLR-6902.patch
>
>
> Finally got annoyed enough with too many things being clubbed into one test
> method in all distributed Solr tests (anything inheriting from
> {{BaseDistributedSearchTestCase}} and currently implementing {{doTest}})..
> This just lays the groundwork really for allowing multiple test methods
> within the same class, and doesn't split tests as yet or flatten the
> inheritance hierarchy (when abused for doing multiple tests), as this touches
> a lot of files by itself. For that reason, the sooner this is picked up the
> better..
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
