[ 
https://issues.apache.org/jira/browse/LUCENE-2694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980748#action_12980748
 ] 

Robert Muir commented on LUCENE-2694:
-------------------------------------

bq. seems like this time perf rules out purity in the interface.

I know i didn't like this aspect of the patch, but I am ok with it for now as 
long as we keep things experimental and try to keep an eye on improving the 
'purity' of TermsEnum a bit.
we are making a lot of progress on the terms handling with flexible indexing 
and i could easily see more interesting implementations being available other 
than just PrefixCoded...
In some ideal world I guess i'd prefer if TermsEnum was an attributesource with 
seek() and next(), FilteredTermsEnum was like tokenFilter, and TermState was 
just captureState/restoreState...
but I agree we should just lean towards whatever works for now.

definitely like it better now that things such as docFreq() are pulled out of 
termstate and its completely opaque, i think this is the right way to go.

> MTQ rewrite + weight/scorer init should be single pass
> ------------------------------------------------------
>
>                 Key: LUCENE-2694
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2694
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Search
>            Reporter: Michael McCandless
>            Assignee: Simon Willnauer
>             Fix For: 4.0
>
>         Attachments: LUCENE-2694-FTE.patch, LUCENE-2694.patch, 
> LUCENE-2694.patch, LUCENE-2694.patch, LUCENE-2694.patch, LUCENE-2694.patch, 
> LUCENE-2694.patch, LUCENE-2694.patch, LUCENE-2694.patch, LUCENE-2694.patch, 
> LUCENE-2694.patch, LUCENE-2694_hack.patch
>
>
> Spinoff of LUCENE-2690 (see the hacked patch on that issue)...
> Once we fix MTQ rewrite to be per-segment, we should take it further and make 
> weight/scorer init also run in the same single pass as rewrite.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to