[
https://issues.apache.org/jira/browse/SOLR-6938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14289450#comment-14289450
]
Alexandre Rafalovitch edited comment on SOLR-6938 at 1/23/15 4:09 PM:
----------------------------------------------------------------------
The JIRA here is not about which one is correct. It is about *discrepancy*
between what was in the config and still is in comments and what the code
actually implements.
So, one way or another, the documentation needs to be brought into alignment.
So, the comments in the schema.xml (all of them I guess), the release notes if
the default changed, the Reference Guide possibly too.
Perhaps it has been done, I didn't check the latest subversion status yet. But,
either way, this cannot be *Won't Fix*. At worst, it's unresolved.
was (Author: arafalov):
The JIRA here is not about which one is correct. It is about *discrepancy*
between what's was in the config and still is in comments and what the code
actually implements.
So, one way or another, the documentation needs to be brought into alignment.
So, the comments in the schema.xml (all of them I guess), the release notes if
the default changed, the Reference Guide possibly too.
Perhaps it has been done, I didn't check the latest subversion status yet. But,
either way, this cannot be *Won't Fix". At worst, it's unresolved.
> Implicit configuration of Update handlers does not match previous explicit one
> ------------------------------------------------------------------------------
>
> Key: SOLR-6938
> URL: https://issues.apache.org/jira/browse/SOLR-6938
> Project: Solr
> Issue Type: Bug
> Components: update
> Affects Versions: 5.0
> Reporter: Alexandre Rafalovitch
> Assignee: Noble Paul
> Fix For: 5.0, Trunk
>
> Attachments: SOLR-6938.patch
>
>
> There seem to be confusion/inconsistency between *contentType* (stream or
> update) parameter as defined in the commented-out update handler and new
> implicit implementation.
> Specifically, in (current 5 build's) techproduct's solrconfig.xml, it says:
> {quote}
> <!-- The following are implicitly added
> <requestHandler name="/update/json" class="solr.UpdateRequestHandler">
> <lst name="defaults">
> <str name="stream.contentType">application/json</str>
> </lst>
> </requestHandler>
> <requestHandler name="/update/csv" class="solr.UpdateRequestHandler">
> <lst name="defaults">
> <str name="stream.contentType">application/csv</str>
> </lst>
> </requestHandler>
> -->
> {quote}
> The documentation also says to use *stream.contentType* at:
> https://cwiki.apache.org/confluence/display/solr/Uploading+Data+with+Index+Handlers
> However, the http://localhost:8983/solr/techproducts/config says instead:
> {quote}
> "/update/json":{
> "name":"/update/json",
> "class":"org.apache.solr.handler.UpdateRequestHandler",
> "defaults":{"update.contentType":"application/json"}},
> "/update/csv":{
> "name":"/update/csv",
> "class":"org.apache.solr.handler.UpdateRequestHandler",
> "defaults":{"update.contentType":"application/csv"}},
> {quote}
> Seems to be pure inconsistency, since Reference Guide does not mention
> *update.contentType*.
> Yet earlier in the same *solrconfig.xml* it says:
> {quote}
> To override the request content type and force a specific
> Content-type, use the request parameter:
> ?update.contentType=text/csv
> {quote}
> Are these different or same? They should definitely be consistent between
> code and comment, but it seems there is a bit of an extra confusion on top.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
