[
https://issues.apache.org/jira/browse/LUCENE-6198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14289665#comment-14289665
]
David Smiley commented on LUCENE-6198:
--------------------------------------
Nice work Rob!
It seems this issue is a solution to LUCENE-6032 right?
I took a look at the patch and have a couple comments. I know you called this a
"hack patch" so that may explain why there are not yet any javadocs on the
methods you added to DocIdSetIterator. The main thing that confuses me about
what I see is the separation between TwoPhase & TwoPhaseApproximation despite
the comments. Couldn't TwoPhase.verify return true, and getApproximation
return ‘this’?
BTW, please don't generalize all geo as being slow; there are multiple
strategies with performance trade-offs for implementing geo.
> two phase intersection
> ----------------------
>
> Key: LUCENE-6198
> URL: https://issues.apache.org/jira/browse/LUCENE-6198
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Robert Muir
> Attachments: LUCENE-6198.patch
>
>
> Currently some scorers have to do a lot of per-document work to determine if
> a document is a match. The simplest example is a phrase scorer, but there are
> others (spans, sloppy phrase, geospatial, etc).
> Imagine a conjunction with two MUST clauses, one that is a term that matches
> all odd documents, another that is a phrase matching all even documents.
> Today this conjunction will be very expensive, because the zig-zag
> intersection is reading a ton of useless positions.
> The same problem happens with filteredQuery and anything else that acts like
> a conjunction.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
