+1 for that re-spin but I'd also give it a day to see if we find more issues there. If everyone wants me to just re-spin it only with this fix, I'm fine with that too.
On Sun, Jan 25, 2015 at 5:43 AM, Erik Hatcher <[email protected]> wrote: > First, thanks Anshum for taking the release bull by the horns. Lucene and > Solr 5.0 is an exciting milestone! > > I’m just starting to run through RC1, and noticed a leftover now-incorrect > bit in solr/CHANGES.txt. I’d say this actually warrants a respin in and > of itself, alas, but of course let’s wait a bit and see if anything more > functional needs fixing. > > -0 for RC1? > > Below is a draft suggested improvement, though relative links and <a>’s > themselves don’t make it through the solr/CHANGES.txt => > solr/build/docs/changes/Changes.html process. I think it’d be better if we > put in a relative link to the built-in docs files rather than pointing to > the external site, to keep things versioned and internally consistent. But > how can we do that here? > > Sorry, I should have caught this one myself long ago. > > Erik > > $ svn diff solr/CHANGES.txt > Index: solr/CHANGES.txt > =================================================================== > --- solr/CHANGES.txt (revision 1654101) > +++ solr/CHANGES.txt (working copy) > @@ -12,11 +12,18 @@ > > Getting Started > --------------- > -You need a Java 1.7 VM or later installed. > -In this release, there is an example Solr server including a bundled > -servlet container in the directory named "example". > -See the Quick Start guide at > http://lucene.apache.org/solr/quickstart.html > +You need a Java 1.7 VM or later installed. See Solr's <a > href="../SYSTEM_REQUIREMENTS.html">system requirements</a> for > +more details. > > +Really quickly, you can get started using Solr with these steps: > + > + # `bin/solr start -e schemaless` > + # `bin/post -c gettingstarted docs/` > + # `open > http://localhost:8983/solr/gettingstarted/browse?q=%22quick+start%22` > + # What you now have is a search engine of Solr's built-in documentation! > + > +For a more thorough yet still quick guide, run through the <a > href="../quickstart.html">Quick Start guide</a>. > + > ================== 5.0.0 ================== > > > > Consult the LUCENE_CHANGES.txt file for additional, low level, changes in > this release > > > > On Jan 25, 2015, at 12:17 AM, Anshum Gupta <[email protected]> > wrote: > > > > Please review and vote for the following RC: > > > > Artifacts: > > > http://people.apache.org/~anshum/staging_area/lucene-solr-5.0.0-RC1-rev1654615 > > > > Smoke tester: > > python3 dev-tools/scripts/smokeTestRelease.py > http://people.apache.org/~anshum/staging_area/lucene-solr-5.0.0-RC1-rev1654615 > > > > Here's my +1 > > > > SUCCESS! [0:39:42.513560] > > > > -- > > Anshum Gupta > > http://about.me/anshumgupta > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > -- Anshum Gupta http://about.me/anshumgupta
