[
https://issues.apache.org/jira/browse/LUCENE-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291720#comment-14291720
]
Sanne Grinovero commented on LUCENE-5569:
-----------------------------------------
As a heavy Lucene consumer I probably have no right at all to complain :)
But now that the time has come to test the candidate release for 5.0, let me
share some facts:
- This change caused some ~600 compile errors in our codebase
- My personal opinion being that {{AtomicReader}} was a very good name, please
take it as a statement that such names are quite a personal choice and someone
just needs to make a call (And stick to it!).
Indeed it's not a major blocker, but as [[email protected]] wisely puts it,
I'd wish the bar against API changes was higher, especially when there isn't a
really good reason.
> Rename AtomicReader to LeafReader
> ---------------------------------
>
> Key: LUCENE-5569
> URL: https://issues.apache.org/jira/browse/LUCENE-5569
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Adrien Grand
> Assignee: Ryan Ernst
> Priority: Blocker
> Fix For: 5.0
>
> Attachments: LUCENE-5569.patch, LUCENE-5569.patch
>
>
> See LUCENE-5527 for more context: several of us seem to prefer {{Leaf}} to
> {{Atomic}}.
> Talking from my experience, I was a bit confused in the beginning that this
> thing is named {{AtomicReader}}, since {{Atomic}} is otherwise used in Java
> in the context of concurrency. So maybe renaming it to {{Leaf}} would help
> remove this confusion and also carry the information that these readers are
> used as leaves of top-level readers?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
