Yeah, they advertise RAT as heuristical, and we are abusing it to detect missing copyright headers for the most part (typically, someone forgets the apache license one). So from time to time we will have to update the heuristics for licenses that it cannot recognize.
On Fri, Jan 30, 2015 at 3:25 AM, Upayavira <[email protected]> wrote: > Thanks Robert, > > I found it confusing because the config for Solr was inside Lucene, not > where I would have expected it, but glad to know I was in the right > place. > > What you said was exactly what I needed. The Rat output shows some JS > libraries as not passing (e.g. angularJS) so I just need to add their > copyright strings to that file, as you say in the right section, and > then rerun 'ant rat-sources'. > > Thanks! > > Upayavira > > On Fri, Jan 30, 2015, at 02:37 AM, Robert Muir wrote: >> You are correct the main logic is in lucene/common-build, I dont see >> why you think that is confusing. Do you think the license verification >> logic shoudl be duplicated twice in the build system? anyway there are >> some hooks like $rat.excludes for a module to override with. >> >> Can you explain a little more what the problem is? (maybe just include >> the output from 'ant rat-sources' that fails) >> >> If the problem is that its a test file or something that should not >> relaly have a license (e.g. its something that an analyzer croaked on >> before), then that rat.excludes is the way to go, just exclude the >> file completely. >> >> otherwise if the license is not recognized, add a substring that would >> identify it to that logic, under the correct category. >> >> On Thu, Jan 29, 2015 at 8:58 PM, Upayavira <[email protected]> wrote: >> > As a part of SOLR5507, I'm trying to get RAT to pass. I've dug around, >> > and got very confused. It seems that the config for Solr RAT is in >> > lucene/common-build.xml, which doesn't make much sense, and there are >> > licenses I can't find in there. >> > >> > Can someone explain to me how I tell RAT that a specific license is >> > acceptable? >> > >> > I suspect I'm missing something obvious. >> > >> > Many thanks! >> > >> > Upayavira >> > >> > --------------------------------------------------------------------- >> > To unsubscribe, e-mail: [email protected] >> > For additional commands, e-mail: [email protected] >> > >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
