[ 
https://issues.apache.org/jira/browse/SOLR-6919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303412#comment-14303412
 ] 

Mark Miller commented on SOLR-6919:
-----------------------------------

bq. FWIW, I only see one other debug statement in SolrCore trunk, and it's in 
an unexpected situation. So I don't think this is high priority.

I'm not really worried about the situation today, I'm worried about it 
tomorrow. Debug is a developers tool and can be put in tight loops or pretty 
much anywhere - SolrCore is a very large class - doing it this way seems like, 
okay, it's fine this release, SolrCore does not currently have a lot of debug 
logging, but it could make it useless on a upgrade, or even essentially cause a 
bug on upgrade as all of a sudden you start pumping out a ton of debug logging 
and have performance issues, flood your log, etc. You don't really want to turn 
on debug logging for Solrcore - you want to turn on pre logging of the query.

> Log REST info before executing
> ------------------------------
>
>                 Key: SOLR-6919
>                 URL: https://issues.apache.org/jira/browse/SOLR-6919
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>            Reporter: Mike Drob
>            Assignee: Gregory Chanan
>            Priority: Minor
>             Fix For: Trunk, 5.1
>
>         Attachments: SOLR-6919.patch, SOLR-6919.patch, SOLR-6919.patch
>
>
> We should log request info (path, parameters, etc...) before attempting to 
> execute a query. This is helpful in cases where we get a bad query that 
> causes OOM or something else catastrophic, and are doing post-event triage.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to