I committed a fix (linter just flat out silently didn't work with Java 8 generated javadocs; now it should).
So now FacetsCollector.needScores is also shown as missing if you use Java 8 before Rob committed the javadocs bug workaround. And I committed the workaround for 3 cases on trunk. Mike McCandless http://blog.mikemccandless.com On Fri, Feb 6, 2015 at 4:11 AM, Michael McCandless <[email protected]> wrote: > I'll dig on why the linter is incorrectly passing with java8.... > > Mike McCandless > > http://blog.mikemccandless.com > > > On Thu, Feb 5, 2015 at 4:30 PM, Robert Muir <[email protected]> wrote: >> it is the common javadocs bug when superclasses implement interfaces >> (same reason why all concrete codec consumer/producers redundantly say >> 'implements Closeable'). >> javadoc for the method is completely empty, and javadoc does not know >> that it is specified by the interface (no specified-by or other links) >> or even the parent superclass! Its like it just gives up. >> >> I will add the useless 'implements' workaround... >> >> why does 'documentation-lint' currently only fail here on java7, but >> pass on java8? I generated javadocs with java8, and it still has the >> problem, yet builds don't fail. >> >> On Thu, Feb 5, 2015 at 3:10 PM, Policeman Jenkins Server >> <[email protected]> wrote: >>> Build: http://jenkins.thetaphi.de/job/Lucene-Solr-5.x-Linux/11581/ >>> Java: 64bit/jdk1.7.0_80-ea-b05 -XX:+UseCompressedOops -XX:+UseParallelGC >>> >>> All tests passed >>> >>> Build Log: >>> [...truncated 45178 lines...] >>> -documentation-lint: >>> [echo] checking for broken html... >>> [jtidy] Checking for broken html (such as invalid tags)... >>> [delete] Deleting directory >>> /mnt/ssd/jenkins/workspace/Lucene-Solr-5.x-Linux/lucene/build/jtidy_tmp >>> [echo] Checking for broken links... >>> [exec] >>> [exec] Crawl/parse... >>> [exec] >>> [exec] Verify... >>> [echo] Checking for missing docs... >>> [exec] >>> [exec] build/docs/facet/org/apache/lucene/facet/FacetsCollector.html >>> [exec] missing Methods: needsScores() >>> [exec] >>> [exec] Missing javadocs were found! >>> >>> BUILD FAILED >>> /mnt/ssd/jenkins/workspace/Lucene-Solr-5.x-Linux/build.xml:529: The >>> following error occurred while executing this line: >>> /mnt/ssd/jenkins/workspace/Lucene-Solr-5.x-Linux/build.xml:83: The >>> following error occurred while executing this line: >>> /mnt/ssd/jenkins/workspace/Lucene-Solr-5.x-Linux/lucene/build.xml:134: The >>> following error occurred while executing this line: >>> /mnt/ssd/jenkins/workspace/Lucene-Solr-5.x-Linux/lucene/build.xml:169: The >>> following error occurred while executing this line: >>> /mnt/ssd/jenkins/workspace/Lucene-Solr-5.x-Linux/lucene/common-build.xml:2481: >>> exec returned: 1 >>> >>> Total time: 77 minutes 52 seconds >>> Build step 'Invoke Ant' marked build as failure >>> [description-setter] Description set: Java: 64bit/jdk1.7.0_80-ea-b05 >>> -XX:+UseCompressedOops -XX:+UseParallelGC >>> Archiving artifacts >>> Recording test results >>> Email was triggered for: Failure - Any >>> Sending email for trigger: Failure - Any >>> >>> >>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [email protected] >>> For additional commands, e-mail: [email protected] >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
