On 2/6/2015 3:19 AM, Alan Woodward wrote: > My patch on LUCENE-4524 is failing ant precommit at the moment, with the > following error: > > RuntimeError: failed to locate javadoc item in > build/docs/core/org/apache/lucene/index/DocsEnum.html, line 166? last line: > </tr> > > The problem is that DocsEnum is now an abstract subclass of PostingsEnum, > which has no constructor and just overrides some methods, so it generates no > method javadoc (everything is inherited), and checkJavaDocs.py doesn't like > that. > > It's fairly easy to fix in this case (just add some dummy javadoc), but I was > wondering if this is something that we should detect and ignore?
This sounds like a similar situation (but maybe not a precise match) to what this commit fixes: http://svn.apache.org/viewvc?view=revision&revision=1657697 That commit addresses a case where a class overrides an interface method implemented by a superclass. The overridden method DOES have javadoc, but this fact is not being detected when JDK7 is used. When running with JDK8, precommit passes without the change, as expected. Thanks, Shawn --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
