[ https://issues.apache.org/jira/browse/LUCENE-3973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14311763#comment-14311763 ]
Mike Drob commented on LUCENE-3973: ----------------------------------- bq. I'm just kind of curious how you envision PMD succeeding when these are still ignored... I imagine that those are ignored because there are so many of them. If we get them down to a good number (i.e. zero) then future ones can be set to fail the build, or at least configured on a Jenkins instance somewhere to fail the build. I am definitely willing to put in the time myself to cut these down; David's suggestion to go by module seems perfectly reasonable to me. We can do javac warnings or PMD warnings or both. Getting the tooling in place is a necessary step in that direction. > Incorporate PMD / FindBugs > -------------------------- > > Key: LUCENE-3973 > URL: https://issues.apache.org/jira/browse/LUCENE-3973 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build > Reporter: Chris Male > Labels: newdev > Attachments: LUCENE-3973.patch, LUCENE-3973.patch, LUCENE-3973.patch, > LUCENE-3973.patch, LUCENE-3973.patch, LUCENE-3973.patch, LUCENE-3973.patch, > LUCENE-3973.patch, core.html, solr-core.html > > > This has been touched on a few times over the years. Having static analysis > as part of our build seems like a big win. For example, we could use PMD to > look at {{System.out.println}} statements like discussed in LUCENE-3877 and > we could possibly incorporate the nocommit / @author checks as well. > There are a few things to work out as part of this: > - Should we use both PMD and FindBugs or just one of them? They look at code > from different perspectives (bytecode vs source code) and target different > issues. At the moment I'm in favour of trying both but that might be too > heavy handed for our needs. > - What checks should we use? There's no point having the analysis if it's > going to raise too many false-positives or problems we don't deem > problematic. > - How should the analysis be integrated in our build? Need to work out when > the analysis should run, how it should be incorporated in Ant and/or Maven, > what impact errors should have. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org